UPDATE_FVWM_SCREEN: respect StartsOnDesk style #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasAdam
force-pushed
the
ta/gh-86
branch
2 times, most recently
from
1c80d27
to
6bafc8c
Compare
Previously, when StartsOnDesk was used, although the desk was correctly set, the desk would never change thereafter, once the window was moved. This was because the UPDATE_FVWM_SCREEN macro assumed it could always update the window, but never took into account that when moving monitors, the desk also needed to be changed. But this can't blindly happen in all cases, as on initla mapping of the window, the UPDATE_FVWM_SCREEN macro would have overriden the StartsOnDesk style. This change introduces a flag to track this as well as reducing the number of assigments which weren't needed when updating the screen. Also removed an extraneous assignment. Helps #86
When deducing if the windows in the stack ring should be compared against, only consider those windows on the same monitor as the current window. Fixes #86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when StartsOnDesk was used, although the desk was correctly
set, the desk would never change thereafter, once the window was moved.
This was because the UPDATE_FVWM_SCREEN macro assumed it could always
update the window, but never took into account that when moving
monitors, the desk also needed to be changed.
But this can't blindly happen in all cases, as on initla mapping of the
window, the UPDATE_FVWM_SCREEN macro would have overriden the
StartsOnDesk style.
This change introduces a flag to track this as well as reducing the
number of assigments which weren't needed when updating the screen.
Also removed an extraneous assignment.
Helps #86