chore: upgrade to polkadot v1.11.0 #889
Conversation
This reverts commit 124e289.
|
Crate versions that have been updated:
Runtime version has been increased. |
|
@Roznovjak xcm pallet can be removed from call filter? |
|
| @@ -330,7 +330,7 @@ fn transfer_and_swap_should_work_with_4_hops() { | |||
|
|
|||
| assert_eq!( | |||
| hydradx_runtime::Currencies::free_balance(IBTC, &AccountId::from(BOB)), | |||
| 549839246387064 | |||
| 549813213291742 | |||
There was a problem hiding this comment.
it seems we still have some leftover tests that break when weight changes. Instead of exact balance checks, we could just check if the balance is bigger than 0, given the assumption that the balance was zero beforehand.
Also for other tests that needed to be adjusted in this file
| #![allow(unused_parens)] | ||
| #![allow(unused_imports)] | ||
| #![allow(clippy::unnecessary_cast)] | ||
| #![allow(missing_docs)] |
There was a problem hiding this comment.
what is the reason that we started having these missing docs warnings for our weight files? Things seem to be documented with doc comments
| if Whitelist::contains(account) { | ||
| return Err(sp_runtime::DispatchError::Other("Account is already in the whitelist")); | ||
| } | ||
| // TODO: verify that the following check can be removed |
| } | ||
| } | ||
|
|
||
| impl xcm_fee_payment_runtime_api::XcmPaymentApi<Block> for Runtime { |
There was a problem hiding this comment.
Can we add some integration tests for this XcmPaymentApi to document how it works?
I don't think we need something complex like this, but some simple one for usage would be handy.
| // Standard Error: 2_626 | ||
| .saturating_add(Weight::from_parts(3_897_612, 0).saturating_mul(c.into())) | ||
| // Minimum execution time: 6_583_000 picoseconds. | ||
| Weight::from_parts(499_280, 0) |
There was a problem hiding this comment.
this is a significant change from 7_618_449, like 15x less, do we know why?
| jsonrpsee = { version = "0.15.1", features = ["server", "macros"] } | ||
| serde = { version = "1.0.136", features = ["derive"] } | ||
| codec = { workspace = true } | ||
| jsonrpsee = { version = "0.23.2", features = ["server", "macros"] } |
There was a problem hiding this comment.
since this is used both in scraper and in node projects, we could do the same as with others
NOTES:
All changes can be found here:
Breaking changes:
Notable changes
System Callbacks: The system pallet gets five new config items - all of which can be safely set to () as default.
Add the ability for MessageQueue to process enqueued messages on idle
Rate limiting for RPC server which can be utilized by the CLI --rpc-rate-limit
Adds pallet-parameters that allows to have parameters for pallet configs that dynamically change at runtime
pallet-migrations is introduced that can be configured in the System of a runtime to act as multi-block migrator.
Add claim_assets extrinsic to pallet-xcm
The construct_runtime macro now generates a test to assert that all GenesisConfigs of all pallets can be build within the runtime.
XCM fee payment API: A runtime API was added for estimating the fees required for XCM execution and delivery.
pallet-xcm's extrinsics teleport_assets and reserve_transfer_assets have been marked as deprecated. Please change their usage to the limited_teleport_assets and limited_reserve_transfer_assets, respectively; or use the generic/flexible transfer_assets extrinsic.
pallet-xcm's extrinsics execute and send have been marked as deprecated. Please change their usage to the new execute_blob and send_blob. There's a new utility in PolkadotJS Apps for encoding XCMs you can use: https://polkadot.js.org/apps/#/utilities/xcm
Migrations: prevent accidentally using inner unversioned migration instead of VersionedMigration
Adds optional HRMP notification handlers to the xcm-executor. These handlers are 3 new config types on the xcm-executor Config trait:
The runtime now can provide a number of predefined presets of RuntimeGenesisConfig struct. This presets are intended to be used in different deployments, e.g.: local, staging, etc, and should be included into the corresponding chain-specs. Having GenesisConfig presets in runtime allows to fully decouple node from runtime types (the problem is described in #1984).
New call hrmp.establish_channel_with_system to allow parachains to establish a channel with a system parachain
(Breaking change) For all authority nodes, the node binary now enforces the presence of a network key, instead of auto-generating when it is absent.
pallet-xcm has a new extrinsic transfer_assets_using_type_and_then for transferring assets from local chain to destination chain using an explicit XCM transfer types for transferring the assets and the fees:
E.g. For transferring a bridged Foreign Assets between local parachains, Asset Hub or the parachain that bridged the asset over must be used as the reserve location. Same when transferring bridged assets back across the bridge, the local bridging parachain must be used as the explicit reserve location.
The new method takes a custom_xcm_on_dest parameter allowing the caller to specify what should happen to the transferred assets once they reach the dest chain. The custom_xcm_on_dest parameter should contains the instructions to execute on dest as a final step. Usually as simple as: Xcm(vec![DepositAsset { assets: Wild(AllCounted(assets.len())), beneficiary }]), but could be something more exotic like sending the assets even further.
Remove XCM SafeCallFilter for chains using Weights::v3