Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process enqueued messages on idle #3844

Merged
merged 11 commits into from
Mar 27, 2024
Merged

process enqueued messages on idle #3844

merged 11 commits into from
Mar 27, 2024

Conversation

ermalkaleci
Copy link
Contributor

This will make it possible to use remaining weight on idle for processing enqueued messages.
More context here #3709

@ermalkaleci ermalkaleci requested a review from a team as a code owner March 26, 2024 14:48
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5664155

@ermalkaleci ermalkaleci requested review from athei and a team as code owners March 26, 2024 16:51
@paritytech-review-bot paritytech-review-bot bot requested a review from a team March 26, 2024 16:52
bkchr
bkchr approved these changes Mar 27, 2024
View reviewed changes
substrate/frame/message-queue/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/message-queue/src/lib.rs Outdated Show resolved Hide resolved
acatangiu
acatangiu approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

cumulus/parachains/runtimes/testing/penpal/src/lib.rs Outdated Show resolved Hide resolved
@acatangiu
Copy link
Contributor

Also needs a prdoc. (e.g. https://github.com/paritytech/polkadot-sdk/blob/master/prdoc/pr_3696.prdoc)

@acatangiu acatangiu added the T2-pallets This PR/Issue is related to a particular pallet. label Mar 27, 2024
acatangiu
acatangiu approved these changes Mar 27, 2024
View reviewed changes
prdoc/pr_3844.prdoc Outdated Show resolved Hide resolved
acatangiu
acatangiu reviewed Mar 27, 2024
View reviewed changes
prdoc/pr_3844.prdoc Outdated Show resolved Hide resolved
@acatangiu acatangiu added this pull request to the merge queue Mar 27, 2024
Merged via the queue into paritytech:master with commit 8342947 Mar 27, 2024
122 of 132 checks passed
@ermalkaleci ermalkaleci deleted the process-enqueued-messages-on-idle branch March 27, 2024 15:59
@Morganamilo Morganamilo mentioned this pull request Apr 4, 2024
Closed
12 tasks
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Apr 9, 2024
@ermalkaleci @acatangiu @dharjeezy
process enqueued messages on idle (paritytech#3844)
3e2fb3b 
This will make it possible to use remaining weight on idle for
processing enqueued messages.
More context here paritytech#3709

---------

Co-authored-by: Adrian Catangiu <[email protected]>
This was referenced Jun 5, 2024
Closed
Closed
Closed
Closed
@ggwpez ggwpez mentioned this pull request Jun 11, 2024
Open
@ahmadkaouk ahmadkaouk mentioned this pull request Jun 19, 2024
Merged
@chungquantin chungquantin mentioned this pull request Aug 13, 2024
Merged
@Roznovjak Roznovjak mentioned this pull request Sep 2, 2024
Merged
@Roznovjak Roznovjak mentioned this pull request Sep 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@acatangiu acatangiu acatangiu approved these changes

@bkchr bkchr bkchr approved these changes

@athei athei Awaiting requested review from athei

Assignees
No one assigned
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ermalkaleci @paritytech-cicd-pr @acatangiu @bkchr @ggwpez