-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify URL parsing for advertise-urls
used by etcd
sidecar
#715
base: master
Are you sure you want to change the base?
Conversation
d904c2b
to
21945e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR @anveshreddy18!
I'm personally not a fan of regular expressions so I've suggested a different way of doing it in my review. If you don't have any objections and think this method is clearer, please go ahead and adapt these changes to the two functions that are using regex.
Thanks.
@anveshreddy18 |
ca645ba
to
93fe1ca
Compare
…ls instead of @ separator
93fe1ca
to
b8964ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
840a487
to
7c62d31
Compare
What this PR does / why we need it:
This PR modifies the parsing logic for the etcd config parameters
initial-advertise-peer-urls
andadvertise-client-urls
as the druid PR #812 now uses proper URLs for these flags instead of@
as separator currently being used.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: