Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify URL parsing for advertise-urls used by etcd sidecar #715

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Modify URL parsing for advertise-urls used by etcd sidecar #715

wants to merge 6 commits into from
+308 −119

Commits on Oct 17, 2024

  1. Use proper URLs for initial-advertise-peer-urls & advertise-client-ur… 

    …ls instead of @ separator
    @anveshreddy18
    anveshreddy18 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    8c632c4 View commit details
    Browse the repository at this point in the history

  2. changes after rebase

    @anveshreddy18
    anveshreddy18 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    b8964ea View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Use list for advertise-client-urls as well

    @anveshreddy18
    anveshreddy18 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    27ca695 View commit details
    Browse the repository at this point in the history

  2. fix tests

    @anveshreddy18
    anveshreddy18 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    62b9767 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Address review comments

    @anveshreddy18
    anveshreddy18 committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    509f905 View commit details
    Browse the repository at this point in the history

  2. fix check error & tests

    @anveshreddy18
    anveshreddy18 committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    7c62d31 View commit details
    Browse the repository at this point in the history