Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace rewrite_tag filter with modify one #172

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Replace rewrite_tag filter with modify one #172

merged 1 commit into from
Jan 21, 2022

Conversation

vlvasilev
Copy link
Contributor

How to categorize this PR?

/area logging
/kind enhancement

What this PR does / why we need it:
This PR removes the rewrite_tag filter in the logging configuration, which is replaced by modify one.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The `rewrite_tag` filter in the logging configuration is replaced by `modify` one

@vlvasilev vlvasilev requested a review from a team as a code owner October 20, 2021 06:12
@gardener-robot gardener-robot added needs/review Needs review area/logging Logging related kind/enhancement Enhancement, improvement, extension size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 20, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 20, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 20, 2021
deitch
deitch reviewed Oct 20, 2021
View reviewed changes
Copy link
Collaborator

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objection, but I am not the right person to comment. I do not understand enough about how the filters work in configmap-logging.yaml to say intelligently if this is good or not, or why.

@vlvasilev
Copy link
Contributor Author

@deitch Gardener is using a fluent-bit as DaemonSet installed on each Seed to scrape the logs from the containers.
The Gardenelet aggregates the filters and parsers from all extension-providers configmap-logging.yaml and insert them into the fluent-bit ConfigMap. The modify filter add __gardener_multitenant_id__ = operator;user to the log record which then is parsed by the gardener fluent-bit-to-loki plugin. This feature is added by this PR.

@deitch
Copy link
Collaborator

deitch commented Oct 20, 2021

Sure. I haven't looked at fluent-bit config in too long, but sure.

deitch
deitch previously approved these changes Oct 20, 2021
View reviewed changes
@rfranzke
Copy link
Member

/rebase

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Jan 20, 2022
rfranzke
rfranzke approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/rebase Needs git rebase needs/review Needs review labels Jan 21, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 21, 2022
@rfranzke rfranzke merged commit 16b1488 into gardener:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

@deitch deitch deitch left review comments

Assignees
No one assigned
Labels
area/logging Logging related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vlvasilev @deitch @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot