Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce multitenant reserved label #110

Conversation

vlvasilev
Copy link
Collaborator

How to categorize this PR?

/kind enhancement
/area logging

What this PR does / why we need it:
With this PR a reserved Loki stream label __gardener_multitenant_id__ is introduced for specifying multiple tenants separated by semicolon.
This will help unload fluent-bit by removing the rewrite tag filters

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

A reserved Loki stream label `__gardener_multitenant_id__` is introduced to specify multiple tenants separated by semicolon.

@gardener-robot gardener-robot added area/logging Logging related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Sep 27, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 27, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 27, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 27, 2021
@vlvasilev vlvasilev force-pushed the introduce-reserve-label-for-multiple-tenants branch from 1e347d1 to c543091 Compare September 27, 2021 11:55
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Sep 27, 2021
@gardener-robot
Copy link

@vlvasilev You need rebase this pull request with latest master branch. Please check.

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 27, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 27, 2021
@vlvasilev vlvasilev force-pushed the introduce-reserve-label-for-multiple-tenants branch from c543091 to 20ee7f4 Compare September 27, 2021 11:59
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 27, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 27, 2021
@vlvasilev vlvasilev merged commit 2b6d59c into gardener:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging Logging related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants