-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(www): improve feedback-widget toggle button and hover state #13923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions (#13497) * chore(gatsby-cli): update reporter to support different reporters * fix isVerbose & remove some binds * fix jest test console mocks
* Added 3 blog posts about WordPress and Gatsby * Changed code images to text, added video demo of wp_trigger_netlify_build, and clarified version of plugin needed. * Changed yarn to npm for code snippets. * Removed breaking tags from post * Update docs/blog/2019-04-04-how-to-build-a-blog-with-wordpress-and-gatsby-part-2/index.md Co-Authored-By: iamtimsmith <[email protected]> * chore: format * Added captions to each of the videos in blog posts * adjust dates for all three posts
* move local plugins doc to the correct directory * fix markdown titles so they are output in pages
* feat: add a community events page This is a WIP for adding a community events page to the site. TODO: - [x] load event data from Airtable - [x] make sure development doesn’t fail if no Airtable API key is found - [x] create a React Hook to load community event data - [ ] create components to display event data on the page - [ ] style the events page - [ ] write copy for the events page - [x] add a link to submit new events * feat: sort and filter events + styles * fix: update schema to reflect field we actually use * feat: add events page to the sidebar * fix: filter at query level instead of with JS * fix: remove unneded connection type def (it will be autocreated from Airtable type def) * fix: add footer links
* Update using-graphql-playground.md Added missing step to require dotenv package, misc formatting changes * Update using-graphql-playground.md Fixes to original commit, now referencing running 'npm run develop' instead of 'gatsby develop' * Update using-graphql-playground.md Added back note for experimental feature * Change instructions for .env file & add link to env vars Co-authored-by: Lennart <[email protected]>
…ges (#11093) * Updating the gatsby-plugin-checker. It now filters out packages that lack a repository, have bad repo links, incorrect name formats, or lack READMEs.
The page title is "Converting a Starter to a Theme" so _"converting your theme to a starter"_ was possibly mistyped.
* plugin authoring blogpost first draft * added Author & Contributor information * Changed link to one that renders correctly Doing this @ChristopherBiscardi since the Gatsby plugin library isn't rendering the images correctly.
* feat(showcase): Add novvum.io to showcase * fix indent
* Added Stylo markdown writing app textually.net website. * chore: format
* Update sourcing-from-buttercms.md * Use as code formatting keyword * Fix format (prettier)
* fix links to new plugin docs * clean up URLs so they work locally * add contributing information for docs renaming * replace visible links in Q and A post * replace the titles I messed up. oops! * once more, with feeling! * time to walk away from the computer 😅
Adding personal website to Gatsby showcase
* Add Penrose GDM to Gatsby sites * lint yml
* Limited to 100 pages rendered. Added search functionality. Fixed variables Updated to work with #13186 * Fix ignore so raw 404 page gets copied over
* chore: adding links to event page copy * Use relative link Co-authored-by: Lennart <[email protected]>
* chore(starters): add gatsby-starter-primer * update tags Co-authored-by: Lennart <[email protected]>
* Clarify language codename * chore(docs): Moved comment to clarify language codename (#13899)
* Update gatsby-transformer-xml README.md * fix typos * add missing curly bracket Co-authored-by: Lennart <[email protected]>
greglobinski
changed the title
[Docs Feedback widget] - ToggleButton patch
[feedback-widget] fix: ToggleButton icon
May 8, 2019
wardpeet
approved these changes
May 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! thanks for fixing @greglobinski
wardpeet
added
the
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
label
May 8, 2019
wardpeet
removed
the
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
label
May 8, 2019
wardpeet
added
the
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
label
May 8, 2019
wardpeet
changed the title
[feedback-widget] fix: ToggleButton icon
fix(www): improve feedback-widget toggle button and hover state
May 8, 2019
marcysutton
pushed a commit
that referenced
this pull request
May 14, 2019
* initial feedback widget integration * update widget with greg's fabulous styles + state * add emotion plugin to jest-preprocess * improve focus management in screens * remove widget from features page * Use design tokens (1/2) There’s more to do, but this is a start… - remove `font-family: sans-serif` along the way - remove components/feedback-widget/presets in favor of utils/presets.breakpoints * fix: height of widget * Use design tokens (2/2) - chose to reduce the border around the „emoji toggle buttons“ from 3 to 1px - add horizontal margin for screens below desktop/lg * Fix max-width, overlapping navigation button for small screens * Swap `breakpoints` -> `mediaQueries Ref. #13388 * fix(www): improve feedback-widget toggle button and hover state (#13923) * fix focus style in Safari * fix React submit issue for keyboard entry * remove unused code
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make the question mark at the end of
Was this doc helpful...
always visible + change the initialToggleButton
's icon to aChat
icon instead of a Question Mark (Docs Feedback widget #13550 (comment))fix rendering issue in
hover
state ([feedback-widget] feat: lazy load feedback widget component #13616 (comment))