Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-remark-images): Escape HTML characters for image caption #14496

Merged
merged 2 commits into from
Jun 25, 2019
Merged

fix(gatsby-remark-images): Escape HTML characters for image caption #14496

merged 2 commits into from
Jun 25, 2019

Conversation

joshuaavalon
Copy link
Contributor

Description

Escape HTML character(s) in alt attribute of <img>.

Related Issues

#14495

@freiksenet
Copy link
Contributor

@joshuaavalon Thanks a lot! Could you run prettier on the code to fix style errors?

Copy link
Contributor

@superhawk610 superhawk610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@freiksenet freiksenet merged commit 9fb78f8 into gatsbyjs:master Jun 25, 2019
@gatsbot
Copy link

gatsbot bot commented Jun 25, 2019

Holy buckets, @joshuaavalon — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@freiksenet
Copy link
Contributor

Thank you @joshuaavalon <3!

johno pushed a commit to johno/gatsby that referenced this pull request Jul 17, 2019
…atsbyjs#14496)

* fix(gatsby-remark-images): Escape HTML characters for image caption

* Fix prettier style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants