Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-remark-images): Escape HTML characters for image caption #14496

Merged
merged 2 commits into from
Jun 25, 2019
Merged

fix(gatsby-remark-images): Escape HTML characters for image caption #14496

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08b37f6
fix(gatsby-remark-images): Escape HTML characters for image caption
joshuaavalon Jun 2, 2019
0dd6be6
Fix prettier style
joshuaavalon Jun 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/gatsby-remark-images/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,9 @@ module.exports = (
const fileNameNoExt = fileName.replace(/\.[^/.]+$/, ``)
const defaultAlt = fileNameNoExt.replace(/[^A-Z0-9]/gi, ` `)

const alt = overWrites.alt
? overWrites.alt
: node.alt
? node.alt
: defaultAlt
const alt = _.escape(
overWrites.alt ? overWrites.alt : node.alt ? node.alt : defaultAlt
)

const title = node.title ? node.title : ``

Expand Down