chore(gatsby-cli): migrate redux folder to typescript

[Kornil]

Description

Migrate /redux folder in gatsby-cli to typescript.

Related Issues

#21995

There are a couple of is one anys that I could not type better. Let me know if you have any feedback.

[Kornil]

I'm not sure how I should handle module.exports syntax. Especially on /redux/index.ts. Any guidance? Test fails are related to that export.

[MichaelDeBoey]

@Kornil you can just use export default

[Kornil]

@Kornil you can just use export default

@MichaelDeBoey so can I increase the scope of the PR to fix all the affected files as well?
Files like
packages/gatsby-cli/src/reporter/loggers/ink/context.js (line 3)
packages/gatsby-cli/src/reporter/loggers/ipc/index.js (line 1)

Import by using the non-default export syntax, so they won't be compatible anymore I believe.

[blainekasten]

I don't see the need for this to be reusable (in the sense of being an export in a common file). Could you just transfer these types to exist on the functions themselves?

[Kornil]

Do you mean to export them types manually instead of an interface? I put them in a different file cause it grew quite a lot.

[Kornil]

Thank you @blainekasten for the tough review, I've commented with an 👍 on each of your comments that I've addressed.

Return types for actions are now fully typed with a clean interface for both the type and payload.

Only one I left out as I feel it is easier to have an object and interface combo vs key -> type for each one.

Few things to note:

• Still not sure how to better type this, google is not helpful at all here.

export default {
  ...bindActionCreators<typeof actions, any>(actions, dispatch),
}

• One Partial is left for the update action, as we can't predict what will update in it.
• Imports are still gonna be broken (and with them, tests) still need to address that discussion.

[pvdz]

Hi. Fwiw, I'm working excessively in the run-queries.js file that's part of this commit. I didn't notice this PR before, sorry about that.

I have some more work left, part of the fast indexes effort, which I hope to wrap up in the next week or so. Meanwhile, expect some more churn like #22932 . Fwiw, I'm trying hard to be a good typing citizen, but the merge conflicts will be hard.

@blainekasten please hold off on merging this until I'm finished, or in between these PR's. (Although tbh I'm wrapping them up in fast cadence so that's hard). Thanks

[MichaelDeBoey]

Any reason for doing it in 2 steps? 🤔

[Kornil]

No particular reason, @blainekasten fixed it by removing the object structure in the commits below, I highly prefer his solution.

[pvdz]

Fwiw, #22932 was merged and will cause merge conflicts.

I have more changes planned for this file, but not made them yet. If somebody can give me an estimate on how far away merging this PR is then I can potentially hold off on further changes. Otherwise I'll have to continue since this is blocking my work on fast filters.

[Kornil]

@pvdz I can get the merge conflicts solved either later today or tomorrow. Not sure about plans for merging.

[blainekasten]

This looks great to me, let's merge it!

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜

N/A

[gatsbot]

Holy buckets, @Kornil — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!