Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gatsby-cli): migrate redux folder to typescript #22292
chore(gatsby-cli): migrate redux folder to typescript #22292
Changes from 4 commits
3a1129f
c432288
79f6bc9
6e19039
0af15b0
dfe9af6
c609b1f
db0d4cd
90b9409
ece8821
d5cb14a
dfea39c
58fb0be
9051b52
1174098
6d22bf3
10a6959
384eb5f
d4dc11f
9a41d2e
f13bd07
2c33e2a
4054170
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the need for this to be reusable (in the sense of being an export in a common file). Could you just transfer these types to exist on the functions themselves?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean to export them types manually instead of an interface? I put them in a different file cause it grew quite a lot.