Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(babel-plugin-remove-graphql-queries): Convert murmur.js #22458

Conversation

zachdtaylor
Copy link
Contributor

Description

Convert packages/babel-plugin-remove-graphql-queries/src/murmur.js to TypeScript.

Related Issues

Related to #21995

@zachdtaylor zachdtaylor requested a review from a team as a code owner March 21, 2020 01:24
@zachdtaylor zachdtaylor changed the title Convert murmur.js to TypeScript chore(babel-plugin-remove-graphql-queries): Convert murmur.js to TypeScript Mar 21, 2020
@parikshitgupta1
Copy link

let's wait

@zachdtaylor
Copy link
Contributor Author

@parikshitgupta1 Is there anything I should change?

Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! this is ready to be merged! 👍

@wardpeet wardpeet changed the title chore(babel-plugin-remove-graphql-queries): Convert murmur.js to TypeScript chore(babel-plugin-remove-graphql-queries): Convert murmur.js May 5, 2020
@wardpeet wardpeet merged commit 8897e4c into gatsbyjs:master May 5, 2020
@gatsbot
Copy link

gatsbot bot commented May 5, 2020

Holy buckets, @zachtylr21 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@zachdtaylor zachdtaylor deleted the ts/packages/babel-plugin-remove-graphql-queries/src/murmur branch May 5, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants