Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(babel-plugin-remove-graphql-queries) Convert babel plugin remove graphql queries/murmur to Typescript #22702

Closed
wants to merge 4 commits into from
Closed

chore(babel-plugin-remove-graphql-queries) Convert babel plugin remove graphql queries/murmur to Typescript #22702

wants to merge 4 commits into from

Conversation

jamesaucode
Copy link
Contributor

Description

Changed babel-plugin-remove-graphql-queries/murmur to typescript. Change it to named export.

Related Issues

Related to #21995 refactoring to typescript

@jamesaucode jamesaucode marked this pull request as ready for review March 31, 2020 22:40
@jamesaucode jamesaucode requested a review from a team as a code owner March 31, 2020 22:40
@jamesaucode jamesaucode changed the title Convert babel plugin remove graphql queries/murmur to TS chore(babel-plugin-remove-graphql-queries) Convert babel plugin remove graphql queries/murmur to TS Apr 2, 2020
@jamesaucode jamesaucode changed the title chore(babel-plugin-remove-graphql-queries) Convert babel plugin remove graphql queries/murmur to TS chore(babel-plugin-remove-graphql-queries) Convert babel plugin remove graphql queries/murmur to Typescript Apr 2, 2020
@pieh
Copy link
Contributor

pieh commented May 4, 2020

Hey @jamesaucode - it seems like #22458 is already doing that? We now have 2 similar PRs

@jamesaucode
Copy link
Contributor Author

Hey @jamesaucode - it seems like #22458 is already doing that? We now have 2 similar PRs

Oh sorry I didn't see that. This can be closed if you decide to go with his PR.

@wardpeet
Copy link
Contributor

wardpeet commented May 5, 2020

Closing this one in favor of the previous one. The other PR was created before this on so it's only fair to use that one.

Thank you for your contribution! And hopefully, you can find something else to work on 🤗

@wardpeet wardpeet closed this May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants