Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge shopify 2.0 into monorepo #31860

Closed
wants to merge 4 commits into from
Closed

Merge shopify 2.0 into monorepo #31860

wants to merge 4 commits into from

Conversation

DanielSLew
Copy link
Contributor

Description

  • This will be a new major release of the Shopify source plugin
  • Merging the new Shopify source plugin to replace the old one
  • Things to specifically pay attention to in this PR review: config files and README

Documentation

  • Information about the source plugin is located in the README file

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 10, 2021
@DanielSLew DanielSLew added the topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem) label Jun 10, 2021
@DanielSLew DanielSLew closed this Jun 10, 2021
@DanielSLew DanielSLew deleted the merge-shopify-2.0-into-monorepo branch June 10, 2021 17:37
@TylerBarnes
Copy link
Contributor

@DanielSLew is this being moved to a different PR?

@DanielSLew
Copy link
Contributor Author

@TylerBarnes Yes I had to merge master so it was easier to just open up another PR then deal w/ the conflicts I forgot to update the CH ticket that points to this though, I'll update it now. The new PR is here #31862

@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet Awaiting requested review from wardpeet

@TylerBarnes TylerBarnes Awaiting requested review from TylerBarnes

@vladar vladar Awaiting requested review from vladar

@sslotsky sslotsky Awaiting requested review from sslotsky

Assignees
No one assigned
Labels
topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielSLew @TylerBarnes @LekoArts