Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(gatsby-source-shopify): Replace with new plugin #31862

Merged
merged 11 commits into from
Jun 16, 2021
Merged

BREAKING(gatsby-source-shopify): Replace with new plugin #31862

merged 11 commits into from
Jun 16, 2021

Conversation

DanielSLew
Copy link
Contributor

Description

  • This will be a new major release of the Shopify source plugin
  • Merging the new Shopify source plugin to replace the old one
  • Things to specifically pay attention to in this PR review: config files and README

Documentation

  • Information about the source plugin is located in the README file

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 10, 2021
@LekoArts LekoArts changed the title merge new shopify plugin into monorepo BREAKING(gatsby-source-shopify): Replace with new plugin Jun 11, 2021
@LekoArts LekoArts added breaking change If implemented, this proposed work would break functionality for older versions of Gatsby topic: source-shopify Related to the gatsby-source-shopify plugin and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 11, 2021
LekoArts
LekoArts previously requested changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this over! Left some first comments

packages/gatsby-source-shopify/.npmignore Show resolved Hide resolved
packages/gatsby-source-shopify/CHANGELOG.md Outdated Show resolved Hide resolved
packages/gatsby-source-shopify/CODEOWNERS Outdated Show resolved Hide resolved
packages/gatsby-source-shopify/README.md Outdated Show resolved Hide resolved
packages/gatsby-source-shopify/README.md Outdated Show resolved Hide resolved
packages/gatsby-source-shopify/package.json Outdated Show resolved Hide resolved
packages/gatsby-source-shopify/package.json Outdated Show resolved Hide resolved
packages/gatsby-source-shopify/package.json Outdated Show resolved Hide resolved
packages/gatsby-source-shopify/package.json Outdated Show resolved Hide resolved
packages/gatsby-source-shopify/package.json Outdated Show resolved Hide resolved
@DanielSLew
Copy link
Contributor Author

Thanks for bringing this over! Left some first comments

Thanks @LekoArts ! Thank you for looking through it :). I made all the changes you suggested and pushed up another commit.

@DanielSLew DanielSLew mentioned this pull request Jun 11, 2021
Closed
@DanielSLew DanielSLew requested a review from LekoArts June 16, 2021 21:20
KyleAMathews
KyleAMathews approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yahoo!

@DanielSLew DanielSLew dismissed LekoArts’s stale review June 16, 2021 22:17

Dismissing it because I've made the changes you suggested but it's not letting me merge this because of this pending review

@KyleAMathews KyleAMathews merged commit 76a040d into master Jun 16, 2021
@KyleAMathews KyleAMathews deleted the merge-new-shopify-plugin-into-monorepo branch June 16, 2021 22:41
This was referenced Jun 23, 2021
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Jan 18, 2022
Open
@Rutam21 Rutam21 mentioned this pull request Dec 14, 2023
Open
@monizb monizb mentioned this pull request Dec 14, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Dec 14, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Dec 14, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Dec 15, 2023
Open
@wizbit wizbit mentioned this pull request Dec 15, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Dec 15, 2023
Open
@saurabharch saurabharch mentioned this pull request Dec 15, 2023
Open
@wizbit wizbit mentioned this pull request Dec 15, 2023
Open
@joeawillis joeawillis mentioned this pull request Dec 15, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Dec 15, 2023
Open
@saurabharch saurabharch mentioned this pull request Dec 15, 2023
Open
@joeawillis joeawillis mentioned this pull request Dec 15, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Jan 5, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Jan 5, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Jan 5, 2024
Open
@monizb monizb mentioned this pull request Jan 5, 2024
Open
@impactyogi impactyogi mentioned this pull request Jan 5, 2024
Open
@wizbit wizbit mentioned this pull request Jan 5, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Jan 6, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Jan 6, 2024
Open
This was referenced Jan 6, 2024
Open
Open
@saurabharch saurabharch mentioned this pull request Jan 6, 2024
Open
@monizb monizb mentioned this pull request Jan 6, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Jan 6, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Jan 6, 2024
Open
@saurabharch saurabharch mentioned this pull request Jan 6, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Jan 6, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Jan 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascorbic ascorbic ascorbic left review comments

@KyleAMathews KyleAMathews KyleAMathews approved these changes

@LekoArts LekoArts Awaiting requested review from LekoArts

Assignees
No one assigned
Labels
breaking change If implemented, this proposed work would break functionality for older versions of Gatsby topic: source-shopify Related to the gatsby-source-shopify plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanielSLew @KyleAMathews @ascorbic @LekoArts