Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command highlighting and possible incorrect command in CONTRIBUTING.md #5082

Merged
merged 2 commits into from
Apr 23, 2018

Conversation

TylerSanford
Copy link
Contributor

@TylerSanford TylerSanford commented Apr 22, 2018

Description

screen shot 2018-04-22 at 4 57 42 pm

Line 44 of CONTRIBUTING.md the command is not highlighting git clone which is a part of the command block.

Also the command git clone [email protected]:<your-username>/gatsby.git doesn't work for me.

Proposed new command line of git clone https://github.com/<your-username>/gatsby.git which does work for me every time.

Steps to reproduce

By viewing the doc CONTRIBUTING.md line 44, also by attempting the command as described: git clone [email protected]:<your-username>/gatsby.git

Expected result

Docs should have the whole command highlighted to eliminate confusion. Also command should properly clone the fork.

Actual result

`[email protected]:~/Desktop$ git clone [email protected]:tylersanford/hello-world.git
Cloning into 'hello-world'...
[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.`

Environment

  • Gatsby version (npm list gatsby): N/A - Doc change
  • gatsby-cli version (gatsby --version): N/A - Doc change
  • Node.js version: node -v: v9.7.1
  • Operating System: macOS High Sierra 10.13.4

File contents (if changed):

CONTRIBUTION.md:
* Clone your fork: git clone https://github.com//gatsby.git``

@gatsbybot
Copy link
Collaborator

Deploy preview for using-drupal ready!

Built with commit 20f831d

https://deploy-preview-5082--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

Deploy preview for gatsbygram ready!

Built with commit 20f831d

https://deploy-preview-5082--gatsbygram.netlify.com

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change and detailed write-up!

@m-allanson m-allanson merged commit a138927 into gatsbyjs:master Apr 23, 2018
@jlengstorf
Copy link
Contributor

Hiya @TylerSanford! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants