Fix getting page resources in page-renderer #7501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for using-styled-components failed. Built with commit 3f0e867 https://app.netlify.com/sites/using-styled-components/deploys/5b7b61e602ed83158a59cdd3 |
|
Deploy preview for using-glamor failed. Built with commit 3f0e867 https://app.netlify.com/sites/using-glamor/deploys/5b7b61e602ed83158a59cdd0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7380
Using directly has the caveat that you can't use it
unless the page resources are already loaded. Which is fine if
you're using it to render behind a modal the page that's already loaded
(the only use case we know of right now). Otherwise it'll break.