Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change gz-collections.yaml spec to support ci configs #970

Merged
merged 8 commits into from
Jul 21, 2023

Conversation

j-rivero
Copy link
Contributor

The PR should not change any existing code but reforms the yaml spec to define how the libs and ci interacts:

  • 872d0df modifies the yaml to include a ci_configs section that can host all related CI details and the different collections only reference them by name. Names are equal to Ubuntu distributions but could be something different.
  • eb54989 modifies gazebo_libs by doing some changes:
    • generate_ciconfigs_by_lib is a parse step that builds an index of ci-configurations supported by each lib. It should help to avoid extra parsing in the diffferent jobs creation.
    • generate_label_by_requirements handles the label selection for the jobs, nvidia or large-memory.
    • The code is not handling the exclude section in ci
    • Rest of the changes are just to adapt the job creation iteration to the new index.

I would not expect any XML code change with the exception of gz-harmonic repo removal since now we are excluding it.

Build is broken now: remember to SQUASH before merging

Signed-off-by: Jose Luis Rivero <[email protected]>
@j-rivero
Copy link
Contributor Author

Oh ignition_collection needs to be migrated, back to draft.

@j-rivero j-rivero marked this pull request as draft July 14, 2023 17:38
@j-rivero
Copy link
Contributor Author

Oh ignition_collection needs to be migrated, back to draft.

ok, ready. CI says that there is no contect change in any job or any new job.

@j-rivero j-rivero marked this pull request as ready for review July 18, 2023 15:51
Signed-off-by: Jose Luis Rivero <[email protected]>
@j-rivero
Copy link
Contributor Author

There is no change in the final XML configurations according to CI, I'm going to merge the PR to create new ones.

@j-rivero j-rivero merged commit be6a8d1 into master Jul 21, 2023
1 check passed
@j-rivero j-rivero deleted the jrivero/ci_configs_for_yaml branch July 21, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant