-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gz-sim: log_record_dbl_pendulum.sdf #1640
Comments
Interested in ! |
It seems like For example, I launched I tries with #1643 aswell and ran into the same issue.. So I think that's really with the playback feature. Any hint ? |
Yes. I can confirm the playback is not working. |
@arjo129 is it a docker related issue or even on an ubuntu host ? How can we progress on this one ? |
It is an issue on the host as well. Im currently investigating. IT might be a bug in the scene broadcaster, |
After some insane Spelunking of the code base there is a bug in the way the GUI and the server synchronize the world name. The GUI client queries what it thinks is the world name. The server sends a world name that does not match what the world name in the log file is. Here is my console output as evidence:
When I run the system in playback mode the GUI and the server are subscribing and advertising to 2 different topics. Currently investigating why we have this regression. Will have a PR for it soon. |
This is related to: gazebosim/gazebo_test_cases#1640 During the refactor of the SimulationRunner we seem to have broken log playback. In our current set up we need a sdf world to start a SimulationRunner. This sdf world is used for parameterizing which services and topics the server should advertise on. The client GUI then queries the server for unning worlds derived from SDFs. Unfortunately, when playing back from a log file, no SDF world is available. All the world information comes directly from the log file. Unfortunately, this means that when we start a playback session the server always responds to the client with a default world. The client then proceeds to listen for the state on `/world/default/state`, however once the server proceeds to run the log files, it publishes the state on `/world/log_pendulum/state`. The current work around this PR proposes is to read the log file during initialization prior to setting up the transport topics. We then set up the relevant topics. There are probably better ways of handling such behaviour, but given the limited time this seemed to be the quickest way to restore functionality. Signed-off-by: Arjo Chakravarty <[email protected]>
PR opened: gazebosim/gz-sim#2590 |
Isn't the issue related to the way gui config is managed ? I see in https://gazebosim.org/api/sim/9/gui_config.html : "For log-playback, the default file is $HOME/.gz/sim/<#>/playback_gui.config". |
hmm, we should check if this is related to gazebosim/gz-sim#2497 |
@azeey I dont think this has to do with config files. Ive got a full fix for this already in gazebosim/gz-sim#2590. Its a regression because of refactors to |
gazebosim/gazebo_test_cases#1640 This commit adds a really simple regression check to make sure we actually publish on the right topic. Signed-off-by: Arjo Chakravarty <[email protected]>
* Adds a regression test for logplayback gazebosim/gazebo_test_cases#1640 This commit adds a really simple regression check to make sure we actually publish on the right topic. Signed-off-by: Arjo Chakravarty <[email protected]> * typo fix Signed-off-by: Arjo Chakravarty <[email protected]> * Make atomic Signed-off-by: Arjo Chakravarty <[email protected]> --------- Signed-off-by: Arjo Chakravarty <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]>
Configuration
Links
Process
Step 1 - Instructions work
Step 2 - Images (if there are any) match the result
The text was updated successfully, but these errors were encountered: