Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a regression test for logplayback fix in #2611 #2619

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

arjo129
Copy link
Contributor

@arjo129 arjo129 commented Sep 12, 2024

Related to:

gazebosim/gazebo_test_cases#1640

This commit adds a really simple regression check to make sure we actually publish on the right topic.

gazebosim/gazebo_test_cases#1640

This commit adds a really simple regression check to make sure we
actually publish on the right topic.

Signed-off-by: Arjo Chakravarty <[email protected]>
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Sep 12, 2024
Signed-off-by: Arjo Chakravarty <[email protected]>
@arjo129 arjo129 requested a review from azeey September 12, 2024 15:06
@arjo129 arjo129 mentioned this pull request Sep 12, 2024
8 tasks
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arjo129 ! Just one minor comment.

test/integration/log_system.cc Outdated Show resolved Hide resolved
@arjo129 arjo129 enabled auto-merge (squash) September 12, 2024 22:11
@arjo129 arjo129 merged commit 0f16949 into gz-sim9 Sep 12, 2024
10 checks passed
@arjo129 arjo129 deleted the arjo/test/regression_for_log_recordgui branch September 12, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants