-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IgnPython: restore PYTHON_EXECUTABLE for now #223
IgnPython: restore PYTHON_EXECUTABLE for now #223
Conversation
The PYTHON_EXECUTABLE cmake variable was replaced by Python3_EXECUTABLE in gazebosim#218 for new versions of cmake. This breaks packages currently using the previous variable name. This restores PYTHON_EXECUTABLE to allow a tick-tock cycle for downstream packages to transition. Signed-off-by: Steve Peters <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @j-rivero didn't sign one commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the regression, did not find it while compiling the whole ignition family. I added a comment for a TODO when me port if to ign-cmake3.
yep I think there's just a DCO sign-off complaint |
* IgnPython: restore PYTHON_EXECUTABLE for now The PYTHON_EXECUTABLE cmake variable was replaced by Python3_EXECUTABLE in gazebosim#218 for new versions of cmake. This breaks packages currently using the previous variable name. This restores PYTHON_EXECUTABLE to allow a tick-tock cycle for downstream packages to transition. Signed-off-by: Steve Peters <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]> Signed-off-by: Harsh Mahesheka <[email protected]>
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-releases-2022-04-27-fortress-citadel/1389/1 |
🦟 Bug fix
Fixes gazebosim/gz-math#401
Summary
The
PYTHON_EXECUTABLE
cmake variable was replaced byPython3_EXECUTABLE
in #218 for new versions of cmake. This breaks packages currently using the previous variable name. This pull request restoresPYTHON_EXECUTABLE
to allow a tick-tock cycle for downstream packages to transition.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.