IgnPython: restore PYTHON_EXECUTABLE for now #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PYTHON_EXECUTABLE cmake variable was replaced by Python3_EXECUTABLE in gazebosim#218 for new versions of cmake. This breaks packages currently using the previous variable name. This restores PYTHON_EXECUTABLE to allow a tick-tock cycle for downstream packages to transition. Signed-off-by: Steve Peters <[email protected]>
github-actions
bot
added
Gazebo 1️1️
j-rivero
approved these changes
Apr 4, 2022
yep I think there's just a DCO sign-off complaint |
harshmahesheka
pushed a commit
to harshmahesheka/ign-cmake
that referenced
this pull request
Apr 5, 2022
* IgnPython: restore PYTHON_EXECUTABLE for now The PYTHON_EXECUTABLE cmake variable was replaced by Python3_EXECUTABLE in gazebosim#218 for new versions of cmake. This breaks packages currently using the previous variable name. This restores PYTHON_EXECUTABLE to allow a tick-tock cycle for downstream packages to transition. Signed-off-by: Steve Peters <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]> Signed-off-by: Harsh Mahesheka <[email protected]>
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-releases-2022-04-27-fortress-citadel/1389/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes gazebosim/gz-math#401
Summary
The
PYTHON_EXECUTABLEcmake variable was replaced byPython3_EXECUTABLEin #218 for new versions of cmake. This breaks packages currently using the previous variable name. This pull request restoresPYTHON_EXECUTABLEto allow a tick-tock cycle for downstream packages to transition.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.