-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ign ➡️ gz] Internal parsed variables #245
Conversation
Signed-off-by: Louise Poubel <[email protected]>
A test build of packages up to I'm not sure what's up, but it might be something wonky with macro substitutions, or worse.., an erroneous macro-set variable that bubbles up into the parent scope that is now causing issues because of the gz change?? |
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/ignitionrobotics/ign-cmake/pull/245/files#diff-955d1f97e2360702839ba9277cc71b9797e65d417d5cb88f383fec0e53ad5124R1000
Found it! Line 1000:
_ign_handle_cxx_standard(ign_create_core_library
-> _ign_handle_cxx_standard(gz_create_core_library
(:
_ign_handle_cxx_standard is a macro that looks for a prefix, not a macro/function name, so we just need to pass in that prefix so it can resolve the appropriate arg!
It builds! (The stderr from math is just the overlay/override check, no worries on that.)
Signed-off-by: Louise Poubel <[email protected]>
Thanks! Well spotted! Committed in e897659 |
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 pending green CI
Summary
This PR updates just the variables parsed by
cmake_parse_arguments
to usegz
instead ofign
. Those variables are internal to each function and shouldn't affect the public API.⬅️ This PR can be backported to
ign-cmake2
later to reduce the diff between the branches.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸