-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ign ➡️ gz] Internal functions #247
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
I'm wondering if it'll make sense to also make function/macro-local variables explicitly private, both:
:O |
I tried to do that using the |
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Because CMake macros do inline text substitution, not really.. unless you define a function inside the macro (with the macro arg as part of the function name) and use that function. But at that point you might as well use a function 😬 Converting macros to functions naively can have follow on consequences though, because macro variables are parent scoped, but function variables are not, which, for this library at least, is probably a lot of work, and not too much of a priority imho. The |
I'll take this to mean that you're not requesting any changes from this PR, @methylDragon . Let me know if you find any issues with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The _ convention is fine then
I'll take this to mean that you're not requesting any changes from this PR, @methylDragon . Let me know if you find any issues with it.
Ah yes!
I think we're good to go? 🤞
Edit: The entire stack up to gazebo7 has built successfully with this version of CMake (:
Summary
Migrate functions that are internal to
gz-cmake
to usegz
instead ofign
. I considered private functions:_
, even if their docs don't say they're private - I'm relying on convention here.It is possible that downstream projects are relying on these functions and will be broken, but that's unlikely. I'd like to reduce our API surface by making as many functions private as possible. This way we can focus our tick-tock efforts into functions that we know are used by downstream projects.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸