Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated CMake functions #252

Merged
merged 2 commits into from
May 9, 2022
Merged

Remove deprecated CMake functions #252

merged 2 commits into from
May 9, 2022

Conversation

chapulina
Copy link
Contributor

Summary

These have been deprecated since cmake2 and can be removed on cmake3.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label May 9, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 9, 2022
@chapulina chapulina mentioned this pull request May 9, 2022
Merged
11 tasks
@chapulina
merged from main
c803b6e 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina enabled auto-merge (squash) May 9, 2022 22:06
@chapulina chapulina merged commit 15b14f2 into main May 9, 2022
@chapulina chapulina deleted the chapulina/3/deprecations branch May 9, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@methylDragon methylDragon Awaiting requested review from methylDragon

@mxgrey mxgrey Awaiting requested review from mxgrey

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @mjcarroll