-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate public ign functions in favor of gz #250
Conversation
ProblemThere's a small issue with the approach you're using for bubbling parsed variables down to a If you have something like SolutionI'd recommend using a prefix to mangle the names. Like Working ExampleSee working example here: https://github.com/gazebosim/gz-gui/pull/395/files#diff-befa40e675cae663c40a34346dbbffd61207a9fac4c557ecc9015786b8bc95c1 |
Thanks for catching that, updated this PR with this pattern |
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: methylDragon <[email protected]> Co-authored-by: methylDragon <[email protected]>
934dc8d
to
0c954ab
Compare
d2c1b2a
to
d019a7c
Compare
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
04dabad
to
b48af54
Compare
Signed-off-by: Louise Poubel <[email protected]>
b48af54
to
7a3a2a3
Compare
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
This PR now builds on top of These are the functions and macros currently migrated by this PR:
There are still some to go. |
Will approve once my local build works with this |
Summary
Deprecate the
ign_
functions that are used by downstream packages and replace them withgz_
counterparts. Warnings are commented out and will be enabled once all our libraries have migrated togz_
.As far as I can tell, CMake doesn't provide a convenient way for a function to forward arguments to another. So I had to play a bit with the scopes to make sure all the values passed in and returned from a function worked correctly.
Here are the rules I came up with:
cmake_parse_arguments
, parse those at the oldign_
function and skip parsing them in the new function with the help of askip_parsing
variable.ign_
wrapper function:Test it
gz_
instead ofign_
and verify that they work the same, without warningsTODO
Keeping as draft until
ign_
functions have been deprecatedChecklist
Added example and/or tutorialConsider updating Python bindings (if the library has them)codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸