Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package create macros for garden #293

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Package create macros for garden #293

wants to merge 2 commits into from

Conversation

harshmahesheka
Copy link
Contributor

@harshmahesheka harshmahesheka commented Jul 30, 2022 •
edited
Loading

🎉 New feature

Implementation of #262 for Garden

Summary

The idea is to create a series of macros that will help new and old users create new packages quickly. This pr changes ign to gz and other small changes to make macors compatible for the garden.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 30, 2022
@chapulina chapulina added the enhancement New feature or request label Jul 30, 2022
@chapulina chapulina requested a review from arjo129 July 30, 2022 04:28
@chapulina chapulina removed the 🌱 garden Ignition Garden label Aug 3, 2022
@chapulina
Copy link
Contributor

Removed the Garden label because the main branch isn't Garden anymore, the new gz-cmake3 branch is.

This PR can be merged into main and backported to gz-cmake3 after the stable release, in October.

arjo129
arjo129 approved these changes Sep 28, 2022
View reviewed changes
Copy link

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address the knit. I'll merge after.

cmake/GzUtils.cmake

list(APPEND plugins_path ${gz_export_msg_INSTALL_DESTINATION})

endmacro()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Knit: add newline at EOF

@azeey
Copy link
Contributor

azeey commented Nov 21, 2022

@j-rivero to review.

@azeey azeey added beta Targeting beta release of upcoming collection and removed beta Targeting beta release of upcoming collection labels Jul 31, 2023
@azeey azeey added beta Targeting beta release of upcoming collection and removed beta Targeting beta release of upcoming collection labels Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjo129 arjo129 arjo129 approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Core development
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshmahesheka @chapulina @azeey @arjo129