-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helper to get version number from package.xml #456
Merged
Merged
+166
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a python script and a cmake helper function for getting the version number from a package.xml file. Signed-off-by: Steve Peters <[email protected]>
This makes the gz_get_package_xml_version function available automatically after finding gz-cmake. Signed-off-by: Steve Peters <[email protected]>
9 tasks
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
j-rivero
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some cosmetic commits, one suggestion and one real fix.
Thanks for the PR!
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Co-authored-by: Jose Luis Rivero <[email protected]> Signed-off-by: Steve Peters <[email protected]>
scpeters
force-pushed
the
scpeters/package_xml_version
branch
from
October 29, 2024 17:08
b35d5d6
to
e14fd45
Compare
j-rivero
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go with green CI ! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Follow-up to gazebosim/gz-math#639, part of gazebosim/sdformat#1491
Summary
This adds a python script and a cmake helper function for getting the version number from a package.xml file.
Test it
Test using the
version_from_package_xml
example.cd examples/version_from_package_xml
mkdir build && cd build
cmake ..
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.