Adds an isRelativePath to determine if path is relative
#312
Conversation
Depends on gazebosim/gz-common#312 See gazebo-tooling/release-tools#639 Basically, this removes the dependency on `std::filesystem` in ign-gazebo as its been causing issues when binaries are produced by diffrent compiler versions. This current version makes sure that we keep all `std::filesystem` code in` ign-common`. Signed-off-by: Arjo Chakravarty <[email protected]>
|
You can target this to ign-common4 |
I think it will actually take a separate implementation since the I wouldn't be opposed to it, because we'll likely need to fix it there for |
Yeah I think the fix will have to be applied separately for fortress and edifice. Makes sense to get this in first cause its easier. I can tackle edifice and fortress tomorrow morning. |
Codecov Report
@@ Coverage Diff @@
## main #312 +/- ##
=======================================
Coverage 76.74% 76.74%
=======================================
Files 75 75
Lines 10323 10325 +2
=======================================
+ Hits 7922 7924 +2
Misses 2401 2401
Continue to review full report at Codecov.
|
This PR adds an `isRelativePath` function to ign-common Filesystem.hh. It is a simple wrapper around `std::filesystem`. The rationale for this is so we can remove `std::Filesystem` from ign-gazebo as this is causing other issues such as gazebo-tooling/release-tools#639. Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
mjcarroll
force-pushed
the
arjo/feat/add_relative_path
branch
from
79f476d
to
b9dad99
Compare
Depends on gazebosim/gz-common#312 See gazebo-tooling/release-tools#639 Basically, this removes the dependency on `std::filesystem` in ign-gazebo as its been causing issues when binaries are produced by diffrent compiler versions. This current version makes sure that we keep all `std::filesystem` code in` ign-common`. Signed-off-by: Arjo Chakravarty <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
🦟 Bug fix
Fixes #
Summary
This PR adds an
isRelativePathfunction to ign-common Filesystem.hh. It is a simple wrapper aroundstd::filesystem. The rationale for this is so we can removestd::filesystemfrom ign-gazebo as this is causing other issues such as gazebo-tooling/release-tools#639.Signed-off-by: Arjo Chakravarty [email protected]
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.