Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 to 5 11302020 #143

Merged
merged 11 commits into from
Dec 9, 2020
Merged

4 to 5 11302020 #143

merged 11 commits into from
Dec 9, 2020

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Dec 9, 2020

Redo after my bad merge.

nkoenig and others added 9 commits November 30, 2020 09:57
)

* Use lowercase resource and owner names when storing assets on disk

Signed-off-by: Nate Koenig <[email protected]>

* Remove added diff text from merge

Signed-off-by: John Shepherd <[email protected]>

* change model version in test back

Signed-off-by: John Shepherd <[email protected]>

* Fix test

Signed-off-by: Nate Koenig <[email protected]>

* Fix windows

Signed-off-by: Nate Koenig <[email protected]>

* Fix more windows tests

Signed-off-by: Nate Koenig <[email protected]>

* Testing another windows fix

Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Co-authored-by: John Shepherd <[email protected]>
* Prepare for 3.5.0 release

Signed-off-by: Nate Koenig <[email protected]>

* Update Changelog.md

Co-authored-by: Louise Poubel <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: John Shepherd <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🔮 dome Ignition Dome labels Dec 9, 2020
@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #143 (a4d2f75) into ign-fuel-tools5 (6e5af74) will increase coverage by 1.46%.
The diff coverage is 46.09%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           ign-fuel-tools5     #143      +/-   ##
===================================================
+ Coverage            76.54%   78.00%   +1.46%     
===================================================
  Files                   19       19              
  Lines                 2554     2601      +47     
===================================================
+ Hits                  1955     2029      +74     
+ Misses                 599      572      -27     
Impacted Files Coverage Δ
src/ign.cc 60.86% <0.00%> (-0.90%) ⬇️
src/FuelClient.cc 70.64% <42.99%> (+4.78%) ⬆️
src/ModelIdentifier.cc 92.35% <100.00%> (+0.09%) ⬆️
src/RestClient.cc 67.91% <100.00%> (+11.42%) ⬆️
src/WorldIdentifier.cc 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e5af74...a4d2f75. Read the comment docs.

nkoenig and others added 2 commits December 9, 2020 13:49
* Support editing/patching model files

Signed-off-by: Nate Koenig <[email protected]>

* Added documentation

Signed-off-by: Nate Koenig <[email protected]>

* Set keep alive on

Signed-off-by: Nate Koenig <[email protected]>

* Documentation and tests

Signed-off-by: Nate Koenig <[email protected]>

* One more test and exit catch missing -u

Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig mentioned this pull request Dec 9, 2020
@chapulina chapulina merged commit 85bb58a into ign-fuel-tools5 Dec 9, 2020
@chapulina chapulina deleted the 4_to_5_11302020 branch December 9, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants