-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Owner upload #179
Owner upload #179
Conversation
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-fuel-tools5 #179 +/- ##
===================================================
- Coverage 77.53% 77.48% -0.05%
===================================================
Files 19 19
Lines 2657 2661 +4
===================================================
+ Hits 2060 2062 +2
- Misses 597 599 +2
Continue to review full report at Codecov.
|
looks like adding an overloaded |
I think the ABI issue was spurious, the latest build passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me! It would be nice to add a test, but I'm not sure how feasible that would be, so I'm ok without one for now.
* Owner upload (#179) Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Louise Poubel <[email protected]> * Fixed windows download (#178) * Fixed donwload on Windows Signed-off-by: ahcorde <[email protected]> * Fixed interface_TEST Signed-off-by: ahcorde <[email protected]> * Improved windows support Signed-off-by: ahcorde <[email protected]> * Make linters happy Signed-off-by: ahcorde <[email protected]> * Make linters happy Signed-off-by: ahcorde <[email protected]> * Improved Signed-off-by: ahcorde <[email protected]> * Fixed test on Windows Signed-off-by: Alejandro Hernández <[email protected]> * Fixed test Signed-off-by: ahcorde <[email protected]> * Fix some nits Signed-off-by: ahcorde <[email protected]> * Improved Windows support Signed-off-by: ahcorde <[email protected]> * Fixed test on Linux Signed-off-by: ahcorde <[email protected]> * make linters happy Signed-off-by: ahcorde <[email protected]> * Fixed windows tests Signed-off-by: ahcorde <[email protected]> * Fixed tests Signed-off-by: ahcorde <[email protected]> * Added feddback Signed-off-by: ahcorde <[email protected]> * make linters happy Signed-off-by: ahcorde <[email protected]> * Remove tools/code_check and update codecov (#187) Signed-off-by: Louise Poubel <[email protected]> * added fuel update command (#185) * added fuel update command Signed-off-by: Tomas Lorente <[email protected]> * fixed header Signed-off-by: Tomas Lorente <[email protected]> * fixed build Signed-off-by: Tomas Lorente <[email protected]> * updated docs Signed-off-by: Tomas Lorente <[email protected]> * added header Signed-off-by: Tomas Lorente <[email protected]> * fix Signed-off-by: Tomas Lorente <[email protected]> * nit2 Signed-off-by: Tomas Lorente <[email protected]> * Style, and headers Signed-off-by: Nate Koenig <[email protected]> * Fixed world download Signed-off-by: Nate Koenig <[email protected]> * Removed debug Signed-off-by: Nate Koenig <[email protected]> * Fix tests Signed-off-by: Nate Koenig <[email protected]> * Fix windows Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * 🎈 4.4.0 (#190) Signed-off-by: Louise Poubel <[email protected]> * Detect ign instead of using cmake module to check for ignition-tools (#191) Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Jose Tomas Lorente <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]>
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1 |
🎉 New feature
Summary
Support specification of owner during model upload.
Test it
Example usage:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge