-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5 ➡️ 6 #197
5 ➡️ 6 #197
Conversation
Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
* Fixed donwload on Windows Signed-off-by: ahcorde <[email protected]> * Fixed interface_TEST Signed-off-by: ahcorde <[email protected]> * Improved windows support Signed-off-by: ahcorde <[email protected]> * Make linters happy Signed-off-by: ahcorde <[email protected]> * Make linters happy Signed-off-by: ahcorde <[email protected]> * Improved Signed-off-by: ahcorde <[email protected]> * Fixed test on Windows Signed-off-by: Alejandro Hernández <[email protected]> * Fixed test Signed-off-by: ahcorde <[email protected]> * Fix some nits Signed-off-by: ahcorde <[email protected]> * Improved Windows support Signed-off-by: ahcorde <[email protected]> * Fixed test on Linux Signed-off-by: ahcorde <[email protected]> * make linters happy Signed-off-by: ahcorde <[email protected]> * Fixed windows tests Signed-off-by: ahcorde <[email protected]> * Fixed tests Signed-off-by: ahcorde <[email protected]> * Added feddback Signed-off-by: ahcorde <[email protected]> * make linters happy Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
* added fuel update command Signed-off-by: Tomas Lorente <[email protected]> * fixed header Signed-off-by: Tomas Lorente <[email protected]> * fixed build Signed-off-by: Tomas Lorente <[email protected]> * updated docs Signed-off-by: Tomas Lorente <[email protected]> * added header Signed-off-by: Tomas Lorente <[email protected]> * fix Signed-off-by: Tomas Lorente <[email protected]> * nit2 Signed-off-by: Tomas Lorente <[email protected]> * Style, and headers Signed-off-by: Nate Koenig <[email protected]> * Fixed world download Signed-off-by: Nate Koenig <[email protected]> * Removed debug Signed-off-by: Nate Koenig <[email protected]> * Fix tests Signed-off-by: Nate Koenig <[email protected]> * Fix windows Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
…191) Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with happy CI
Codecov Report
@@ Coverage Diff @@
## ign-fuel-tools6 #197 +/- ##
===================================================
- Coverage 77.47% 75.55% -1.92%
===================================================
Files 20 20
Lines 2672 2757 +85
===================================================
+ Hits 2070 2083 +13
- Misses 602 674 +72
Continue to review full report at Codecov.
|
@osrf-jenkins retest this please |
new windows test failure:
|
I see this failing on I believe it's caused by some change upstream on I'm going to merge this PR since it didn't introduce the only test failure, and it fixes some of the test failures currently in |
➡️ Forward port
Port ign-fuel-tools5 to ign-fuel-tools6
Branch comparison: ign-fuel-tools6...ign-fuel-tools5
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)