-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added camera tracking #226
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
* Add sky tag to the new Scene3D Signed-off-by: ahcorde <[email protected]> * Update docs Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is still WIP, but I'll leave a note to myself that this PR doesn't compile by itself:
/home/chapulina/dev_bionic/ws_fortress/src/ign-gui/src/plugins/camera_controller_manager/CameraControllerManager.cc:434:63: error: 'KeyReleaseToScene' in namespace 'ignition::gui::events' does not name a type
events::KeyReleaseToScene *keyEvent = static_cast<events::KeyReleaseToScene*>(_event);
src/plugins/camera_controller_manager/CameraControllerManager.cc
Outdated
Show resolved
Hide resolved
src/plugins/camera_controller_manager/CameraControllerManager.hh
Outdated
Show resolved
Hide resolved
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
…anager Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me! I pushed some changes in 5fc8a01:
- Added to
scene.config
- Added manual testing instructions to
scene_provider
I think this would be a good opportunity to add tests, what do you think? 😇
Codecov Report
@@ Coverage Diff @@
## main #226 +/- ##
==========================================
+ Coverage 61.57% 65.24% +3.66%
==========================================
Files 21 27 +6
Lines 2803 3979 +1176
==========================================
+ Hits 1726 2596 +870
- Misses 1077 1383 +306
Continue to review full report at Codecov.
|
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
I added a test and some other final tweaks in 3a5ae75. I think this is ready! Update: almost ready! |
///////////////////////////////////////////////// | ||
void CameraTrackingPrivate::Initialize() | ||
{ | ||
// Attach to the first camera we find |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to sort this out to make sure we're not attaching to a plugin, see #231 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in as is for now and handle choosing the camera in a future PR, added an item here: #137 (comment)
@@ -44,7 +44,7 @@ set(IGN_MATH_VER ${ignition-math6_VERSION_MAJOR}) | |||
|
|||
#-------------------------------------- | |||
# Find ignition-common | |||
ign_find_package(ignition-common4 REQUIRED VERSION 4.1) | |||
ign_find_package(ignition-common4 REQUIRED COMPONENTS profiler VERSION 4.1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a nightly build failure is a good reminder to update the Debian metadata with this new dependency
CMake Error at /usr/share/cmake/ignition-cmake2/cmake2/IgnConfigureBuild.cmake:59 (message):
-- Missing dependency [ignition-common4] (Components: profiler)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add these to the buildfarmer's dashboard 😏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will be learning about that soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can start by adding them to our Jenkins views: gazebo-tooling/release-tools#491
Signed-off-by: ahcorde [email protected]
🎉 New feature
Summary
This PR is part of the consolidation between the scene3d in ign-gui and ign-gazebo.
This plugin allows to
follow
andmoveto
the camera. This requires to change a small detail in ign-gui scene3D when we create the camera, instead of using the methodcreateCamera(void)
we should usecreateCamera(string)
. Then we will be able to fetch the camera from this plugin.Related PRs:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge