-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added service to set camera's follow offset #855
Conversation
Signed-off-by: Jenn Nguyen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo4 #855 +/- ##
===============================================
- Coverage 65.72% 65.69% -0.03%
===============================================
Files 240 240
Lines 17783 17797 +14
===============================================
+ Hits 11687 11691 +4
- Misses 6096 6106 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, works for me
while reviewing this PR, I found a small bug related to the camera follow offset checks and addressed it in #857 |
I'll try this out with some log files soon. Please wait for my approval before merging. |
🎉 New feature
Summary
Added service
/gui/follow/offset
to set the user camera's follow offset.Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge