-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3 ➡️ 4 #234
3 ➡️ 4 #234
Conversation
Signed-off-by: Steve Peters <[email protected]>
We aren't using QTest anymore in ign-gui, so remove the parts of check_test_ran.py that translated QTest xml files into junit, since they don't work easily on Windows and aren't needed any longer. Fixes #198. Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
) Signed-off-by: ahcorde <[email protected]>
* Start porting events from ign-gazebo Signed-off-by: Louise Poubel <[email protected]> * Remove test that fails due to #216 Signed-off-by: Louise Poubel <[email protected]> * Move Scene3d_TEST.cc to test/integration There seems to be a problem with loading the ignition-rendering-ogre plugin from the Scene3D test if it links to that plugin. Making Scene3D_TEST.cc into an integration test works because it doesn't directly call any plugin methods. This also changes the linking for the Grid3D plugin to only link to the ignition-rendering core library target instead of the IGNITION-RENDERING_LIBRARIES variable which includes the ogre component library plugins. Signed-off-by: Steve Peters <[email protected]> * process qt events to allow scene to initialize Signed-off-by: Steve Peters <[email protected]> * Add test helper to check event Signed-off-by: Louise Poubel <[email protected]> * added more tests Signed-off-by: ahcorde <[email protected]> * make linters happy Signed-off-by: ahcorde <[email protected]> * Move TestHelper code to .cc file, fix windows? Signed-off-by: Steve Peters <[email protected]> * Fix windows? Signed-off-by: ahcorde <[email protected]> * Fix windows? Signed-off-by: Alejandro Hernández <[email protected]> * Expect values of Vector3 point in click events Signed-off-by: Steve Peters <[email protected]> * Remove debug message Signed-off-by: Steve Peters <[email protected]> * Remove unused variable Signed-off-by: Steve Peters <[email protected]> Co-authored-by: Steve Peters <[email protected]> Co-authored-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
* Adds confirmation dialog when closing window * Updates docs and extends test coverage. * Adds dialog_on_exit atribute to example .config Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it requires a ignition-rendering4
release
@osrf-jenkins retest this please |
Codecov Report
@@ Coverage Diff @@
## ign-gui4 #234 +/- ##
============================================
+ Coverage 61.57% 65.68% +4.10%
============================================
Files 21 24 +3
Lines 2790 3083 +293
============================================
+ Hits 1718 2025 +307
+ Misses 1072 1058 -14
Continue to review full report at Codecov.
|
MacOS failure depends on this PR osrf/homebrew-simulation#1517 |
Signed-off-by: Louise Poubel <[email protected]>
➡️ Forward port
Port
ign-gui3
toign-gui4
Branch comparison: ign-gui4...ign-gui3
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸