Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent MinimalScene 💥 if another scene is already loaded #364

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

This is the same fix as the PRs below, applied to the MinimalScene.

The MinimalScene required one extra detail. Because of all the render syncing going on, I had to explicitly shutdown the RenderWindowItem to stop all the connections from being fired.

mini_boom

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina requested a review from jennuine as a code owner March 3, 2022 21:39
@chapulina chapulina added the OOBE 📦✨ Out-of-box experience label Mar 3, 2022
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 3, 2022
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #364 (be8668d) into ign-gui6 (dc268fe) will decrease coverage by 0.01%.
The diff coverage is 70.49%.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gui6     #364      +/-   ##
============================================
- Coverage     65.40%   65.38%   -0.02%     
============================================
  Files            39       39              
  Lines          5079     5117      +38     
============================================
+ Hits           3322     3346      +24     
- Misses         1757     1771      +14     
Impacted Files Coverage Δ
src/Application.cc 85.35% <33.33%> (-0.45%) ⬇️
src/plugins/minimal_scene/MinimalScene.cc 63.15% <72.41%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc268fe...be8668d. Read the comment docs.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested

@chapulina chapulina merged commit 70255cc into ign-gui6 Mar 3, 2022
@chapulina chapulina deleted the chapulina/6/min_scene_boom branch March 3, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress OOBE 📦✨ Out-of-box experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants