Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent GzScene3D 💥 if another scene is already loaded #1294

Merged
merged 2 commits into from
Jan 18, 2022

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

Current issue:

  1. Start ign gazebo
  2. From the top-right menu, select Gz Scene 3D
  3. Wait a bit
  4. 💥

This PR prevents a crash and prints a message explaining to the user what happened.

gzscene_boom

The message will be printed if there's any other plugin already loading a render engine, so it's compatible with both GzScene3D and Scene3D.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added bug Something isn't working OOBE 📦✨ Out-of-box experience labels Jan 14, 2022
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jan 14, 2022
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #1294 (a7f28f6) into ign-gazebo3 (700b369) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3    #1294      +/-   ##
===============================================
+ Coverage        77.21%   77.25%   +0.04%     
===============================================
  Files              227      227              
  Lines            13535    13535              
===============================================
+ Hits             10451    10457       +6     
+ Misses            3084     3078       -6     
Impacted Files Coverage Δ
src/SimulationRunner.cc 94.51% <0.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 700b369...a7f28f6. Read the comment docs.

Copy link
Contributor

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works for me.

@chapulina chapulina merged commit 6f58c91 into ign-gazebo3 Jan 18, 2022
@chapulina chapulina deleted the chapulina/3/graceful_scene3d branch January 18, 2022 16:57
@chapulina chapulina mentioned this pull request Jan 28, 2022
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🏰 citadel Ignition Citadel OOBE 📦✨ Out-of-box experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants