Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sending proto definitions from the websocket server #21

Merged
merged 21 commits into from
Jun 1, 2020

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Apr 21, 2020

This updates allow a websocket client to get protobuf message definitions from the server.

Also included in an Ignition javascript library that simplifies connecting to a websocket server.

@osrf-jenkins
Copy link
Collaborator

Build finished.

@nkoenig nkoenig self-assigned this Apr 22, 2020
@nkoenig nkoenig changed the base branch from throttle_websocket to feature/websockets May 7, 2020 00:14
Copy link
Contributor

@german-e-mas german-e-mas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a small comment on the ign file.

plugins/websocket_server/ign.js Outdated Show resolved Hide resolved
Nate Koenig and others added 2 commits June 1, 2020 10:42
@nkoenig nkoenig merged commit dfaecec into feature/websockets Jun 1, 2020
@nkoenig nkoenig deleted the websocket_update branch June 1, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants