Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.2.0 #65

Merged
merged 2 commits into from
Nov 16, 2020
Merged

2.2.0 #65

merged 2 commits into from
Nov 16, 2020

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Oct 14, 2020

Signed-off-by: Nate Koenig [email protected]

@scpeters
Copy link
Member

homebrew build failed because ign-gazebo 3.4 bottle hadn't finished building, but I just merged it in osrf/homebrew-simulation#1182

@chapulina
Copy link
Contributor

homebrew build failed because ign-gazebo 3.4 bottle hadn't finished building

We should probably bump the minimum required ign-gazebo version before merging this then.

Signed-off-by: Nate Koenig <[email protected]>
@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #65 (74e6218) into ign-launch2 (7b63e1f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-launch2      #65   +/-   ##
============================================
  Coverage        29.01%   29.01%           
============================================
  Files                3        3           
  Lines              734      734           
============================================
  Hits               213      213           
  Misses             521      521           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b63e1f...74e6218. Read the comment docs.

@chapulina
Copy link
Contributor

We should probably bump the minimum required ign-gazebo version before merging this then.

Doing it on #64, which adds the dependency. That CI is currently failing on Focal because the 3.4 release failed for that distro.

Base automatically changed from nate/1_to_2_2020_10_14 to ign-launch2 November 16, 2020 17:00
@chapulina chapulina added the 🏰 citadel Ignition Citadel label Nov 16, 2020
@chapulina chapulina merged commit 0986169 into ign-launch2 Nov 16, 2020
@chapulina chapulina deleted the prepare_2_2_0 branch November 16, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants