Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A segfault can occur if a websocket disconnects while the websocket server is handling a new ign-transport message.
The addition of
std::lock_guard<std::mutex> mainLock(this->subscriptionMutex);
resolves the problem, and the extraif (this->connections.find(socketId) != this->connections.end())
is just for good measure.Signed-off-by: Nate Koenig [email protected]