3.1.0 release prep

[nkoenig]

Changes.

Signed-off-by: Nate Koenig [email protected]

[codecov]

Codecov Report

Merging #78 (5edccf2) into ign-launch3 (2c458d4) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           ign-launch3      #78   +/-   ##
============================================
  Coverage        29.01%   29.01%           
============================================
  Files                3        3           
  Lines              734      734           
============================================
  Hits               213      213           
  Misses             521      521           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c458d4...5edccf2. Read the comment docs.

[adlarkin]

I don't see PR #68 in the changelog, but it's in the branch comparison - would it be worth adding this to the changelog?

[mjcarroll]

I don't see PR #68 in the changelog, but it's in the branch comparison - would it be worth adding this to the changelog?

Probaby because it landed in 1.x, so it falls under the "everything up to x.x.x" description.

[adlarkin]

Probaby because it landed in 1.x, so it falls under the "everything up to x.x.x" description.

Looks like #68 was merged on 2020-10-26, but the latest 1.x release was on 2020-09-25, and the latest 2.x release was on 2020-10-14. So, #68 was merged after the latest 1.x and 2.x releases, which makes me think that this PR didn't land in 1.x - is there something I'm missing here?

Edit: Just saw 5edccf2, I think everything is good to go!

[nkoenig]

Thanks, I just added it in: 5edccf2

[mjcarroll]

Oh, I see, it's on the 1.x branch but has not been released yet. Now that we are generating changelogs at the time of release (vs time the feature is added), it's not in there.

[adlarkin]

Oh, I see, it's on the 1.x branch but has not been released yet. Now that we are generating changelogs at the time of release (vs time the feature is added), it's not in there.

That's true, I just realized the race condition PR was merged into the ign-launch1 branch, but we haven't had a 1.x release since that merge, right? So does that mean this PR shouldn't be a part of 1.x in the changelog? Should it be a part of 3.x instead?