-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python interface: Renames methods to match PEP8 style #226
Conversation
Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-math6 #226 +/- ##
==========================================
Coverage 99.21% 99.21%
==========================================
Files 65 65
Lines 6089 6089
==========================================
Hits 6041 6041
Misses 48 48 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, LGTM!
We could use one more review @chapulina @scpeters . 😃 🙏 Once this PR gets merged, the open PRs that add python interfaces for more classes should be updated. CC: @LolaSegura @WagnerMarcos |
I tried running
I think we can ignore this though |
🎉 New feature
Related to #101 #210
Summary
Vector2
,Vector3
,Vector4
,Angle
,GaussMarkovProcess
andRand
classes to match PEP8 style.rename
SWIG directives to rename methods when creating the python bindings. (Aligned with PEP8 specification.)Python
we need to rename the methods but that's not the case forRuby
.For reviewers
I suggest to review commit by commit:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge