-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds python interface to Filter, MovingWindowFilter, RotationSpline. #230
Adds python interface to Filter, MovingWindowFilter, RotationSpline. #230
Conversation
Signed-off-by: LolaSegura <[email protected]>
Signed-off-by: LolaSegura <[email protected]>
Signed-off-by: LolaSegura <[email protected]>
Signed-off-by: LolaSegura <[email protected]>
Signed-off-by: LolaSegura <[email protected]>
Signed-off-by: LolaSegura <[email protected]>
…tyle. Signed-off-by: LolaSegura <[email protected]>
…hon test to the python folder. Signed-off-by: LolaSegura <[email protected]>
Signed-off-by: LolaSegura <[email protected]>
Signed-off-by: LolaSegura <[email protected]>
Signed-off-by: LolaSegura <[email protected]>
Signed-off-by: LolaSegura <[email protected]>
Signed-off-by: LolaSegura <[email protected]>
This PR is on hold until #221 is merged. |
Codecov Report
@@ Coverage Diff @@
## ign-math6 #230 +/- ##
==========================================
Coverage 99.40% 99.40%
==========================================
Files 66 66
Lines 6185 6185
==========================================
Hits 6148 6148
Misses 37 37 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'll solve the conflicts after #221 is merged. |
…ter_rotation-spline
src/python/MovingWindowFilter.i
Outdated
#include "ignition/math/Vector3.hh" | ||
%} | ||
|
||
%import "std_vector.i" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this line fixes the compilation error for me. Maybe it's a known issue, but I had to touch python.i
for it to recompile this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me take a look. It seemed to be working before merging this branch with ign-math6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You were right. That import was causing issues because of the syntaxis: it should be include
instead of import
The truth is that that import wasn't necessary given that std::vector
isn't being used in the API, so that import statement wasn't needed at all. I pushed the fix
Signed-off-by: Franco Cipollone <[email protected]>
6d6708d
to
7ebbcc7
Compare
Signed-off-by: Steve Peters <[email protected]>
🎉 New feature
Goes on top of #221
Related to #101 #210
Summary
Adds Python interface for three math classes: Filter, MovingWindowFilter and RotationSPline. For each class a python test has been created.
Related issues and notes
Filter
The
Filter.hh
file contains various template classes that inherit from aFilter
class, which is a template class itself. To create binding for this classes an instance ofFilter<type>
had to be declared previously.There were some classes that inherit from an instance of another class. For example
class OnePoleQuaternion : public OnePole<math::Quaterniond>
. This wasn't being interpreted by swig as expected. The inherited methods that were not override, were not being created in the binding. The solution we implemented for this was define these classes inside the interface file without the inheritance and adding the methods that were not being created. A similar approach was taken in theSignalStats
class (#220 ).Checklist
codecheck
passed (See contributing)