Use ImplPtr, fix rule of 0 #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Peters <[email protected]>
Move using namespace statements after private class. Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
ahcorde
approved these changes
Jul 15, 2024
mjcarroll
reviewed
Jul 15, 2024
| // Forward declarations. | ||
| class MecanumDriveOdometryPrivate; | ||
|
|
||
| // |
include/gz/math/SpeedLimiter.hh
Outdated
| // Forward declaration. | ||
| class SpeedLimiterPrivate; | ||
|
|
||
| // |
| #ifdef _WIN32 | ||
| #pragma warning(pop) | ||
| #endif | ||
| GZ_UTILS_IMPL_PTR(dataPtr) |
There was a problem hiding this comment.
Suggested change
| GZ_UTILS_IMPL_PTR(dataPtr) | |
| /// \brief Private data pointer. | |
| GZ_UTILS_IMPL_PTR(dataPtr) |
Here and elsewhere
Signed-off-by: Steve Peters <[email protected]>
adityapande-1995
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Use gz/utils/ImplPtr and fix rule of 0 violations
Summary
This switches from raw data pointers to
gz::utils::ImplPtrforSpeedLimiterandMecanumOdometryand deletes the destructor definitions to satisfy the rule of 0 for these classes.Also remove some unneeded forward
classdeclarations.Test it
Build and run unit tests.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.