-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ImplPtr, fix rule of 0 #608
Conversation
Signed-off-by: Steve Peters <[email protected]>
Move using namespace statements after private class. Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
// Forward declarations. | ||
class MecanumDriveOdometryPrivate; | ||
|
||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include/gz/math/SpeedLimiter.hh
Outdated
// Forward declaration. | ||
class SpeedLimiterPrivate; | ||
|
||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#ifdef _WIN32 | ||
#pragma warning(pop) | ||
#endif | ||
GZ_UTILS_IMPL_PTR(dataPtr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GZ_UTILS_IMPL_PTR(dataPtr) | |
/// \brief Private data pointer. | |
GZ_UTILS_IMPL_PTR(dataPtr) |
Here and elsewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Steve Peters <[email protected]>
🎉 New feature
Use gz/utils/ImplPtr and fix rule of 0 violations
Summary
This switches from raw data pointers to
gz::utils::ImplPtr
forSpeedLimiter
andMecanumOdometry
and deletes the destructor definitions to satisfy the rule of 0 for these classes.Also remove some unneeded forward
class
declarations.Test it
Build and run unit tests.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.