Added field to light.proto to define if a light is on or off

[ahcorde]

Signed-off-by: ahcorde [email protected]

🎉 New feature

Related with :

• Allow to turn on/off lights gz-sim#1343
• Added to light if the light is on or off sdformat#851

Summary

Added field to light.proto to define if a light is on or off

Test it

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[ahcorde]

@osrf-jenkins retest this please

[codecov]

Codecov Report

Merging #223 (0bb9f48) into main (400764d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #223   +/-   ##
=======================================
  Coverage   85.46%   85.46%           
=======================================
  Files           9        9           
  Lines         956      956           
=======================================
  Hits          817      817           
  Misses        139      139           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 400764d...0bb9f48. Read the comment docs.

[chapulina]

Something to keep in mind regarding boolean fields is that they default to false if unset. This means that any message not populating this field will have the light turned off. This may cause issues for users migrating from Fortress to Garden.

I'd suggest flipping the field's name so that the default behavior (light on) happens when the field is unset. i.e.

msgs::Light lightMsg;
assert(!lightMsg.is_light_off());