-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added render order to material #188
Conversation
ea0e9a4
to
a1d972c
Compare
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
54f35d5
to
b50de42
Compare
Retargeted to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, I tried the demo on #190 with Ogre 1 and 2. I think a test could be added which checks that all pixels are the expected color, but I'll leave that up to you if you think it's worth it.
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. Just a few comments on the tutorial. Can you also add the tutorial to tutorials.md.in
?
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #188 +/- ##
==========================================
- Coverage 53.08% 53.08% -0.01%
==========================================
Files 143 143
Lines 13545 13568 +23
==========================================
+ Hits 7191 7203 +12
- Misses 6354 6365 +11
Continue to review full report at Codecov.
|
The goal of this PR is to add the feature
render order
in case some meshes in the scene are coplanar. With this parameter will avoid the artifact generated by z-fighting.Coplanar planes issues:
Fixed:
This PR depends on:
ign-msgs Added render order to material msgs gz-msgs#118ign-common Added render order to material class gz-common#142sdformat10 Added render_order to material sdformat#446Signed-off-by: ahcorde [email protected]