Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extending simple_demo to include render order #190

Merged
merged 7 commits into from
Dec 29, 2020
Merged

Extending simple_demo to include render order #190

merged 7 commits into from
Dec 29, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Dec 23, 2020

Tutorial to explain the render order.

Depends on this PR #188

Signed-off-by: ahcorde [email protected]

ahcorde and others added 3 commits December 7, 2020 16:18
@ahcorde
remove some windows warnings (#183)
26497e7 
Signed-off-by: ahcorde <[email protected]>
@iche033
Fix transparency issue for textures without alpha channel (#186)
2c85d92 
* fix alpha

Signed-off-by: Ian Chen <[email protected]>

* Fix codecheck

Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
@ahcorde
Extending simple_demo to include render order
1a5a3e2 
Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde requested a review from iche033 December 23, 2020 17:49
@ahcorde ahcorde self-assigned this Dec 23, 2020
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Dec 23, 2020
@codecov
Copy link

codecov bot commented Dec 23, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (ahcorde/feature/renderOrder@f4232fb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                      Coverage Diff                       @@
##             ahcorde/feature/renderOrder     #190   +/-   ##
==============================================================
  Coverage                               ?   52.58%           
==============================================================
  Files                                  ?      143           
  Lines                                  ?    13337           
  Branches                               ?        0           
==============================================================
  Hits                                   ?     7013           
  Misses                                 ?     6324           
  Partials                               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4232fb...4076bf8. Read the comment docs.

@chapulina chapulina changed the base branch from ign-rendering4 to ahcorde/feature/renderOrder December 28, 2020 23:36
chapulina
chapulina approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a few typo fixes in 70e745e.

I also merged #188 into this PR and retargeted this PR, because the example added here needs that to work.

This works for me. I'll just point out that whenever we add something to simple_demo, the screenshots (and possibly explanations) we have for older tutorials become outdated.

@chapulina
Copy link
Contributor

I'll merge this into #188 so they can be merged together afterwards.

@chapulina chapulina merged commit 27574a3 into ahcorde/feature/renderOrder Dec 29, 2020
@chapulina chapulina deleted the ahcorde/tutorial/renderOrder branch December 29, 2020 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@iche033 iche033 Awaiting requested review from iche033

Assignees

@ahcorde ahcorde

Labels
🔮 dome Ignition Dome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @chapulina @iche033