👩🌾 Clear all Windows warnings #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
chapulina
added
tests
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-rendering3 #206 +/- ##
==================================================
- Coverage 50.45% 50.35% -0.10%
==================================================
Files 129 129
Lines 11754 11782 +28
==================================================
+ Hits 5930 5933 +3
- Misses 5824 5849 +25
Continue to review full report at Codecov.
|
|
Oh look at that, a ✔️ on Windows 😱 |
j-rivero
reviewed
Jan 27, 2021
| @@ -380,7 +380,7 @@ void OgreMovableText::SetFontNameImpl(const std::string &_newFontName) | |||
| #if OGRE_VERSION_LT_1_10_1 | |||
| this->ogreMaterial.setNull(); | |||
| #else | |||
| this->ogreMaterial == nullptr; | |||
| this->ogreMaterial = nullptr; | |||
There was a problem hiding this comment.
uh .. this one was important
j-rivero
approved these changes
Jan 27, 2021
There was a problem hiding this comment.
Holy cow @chapulina , I take my hat off 🎩 . I think that there is valuable information about how to solve the different Windows warnings in changes in this PR and the description. At least mentioning it in the weekly meeting could be a good idea.
Cool, I added an item for us not to forget 🎉 |
chapulina
commented
Jan 28, 2021
| @@ -28,10 +37,10 @@ set_property( | |||
| target_link_libraries(${ogre_target} | |||
| PUBLIC | |||
| ${ignition-common${IGN_COMMON_VER}_LIBRARIES} | |||
| IgnOGRE::IgnOGRE | |||
There was a problem hiding this comment.
I think this broke downstream libraries like ign-gui:
CMake Error at src/plugins/CMakeLists.txt:29 (add_library):
Target "Grid3D" links to target "IgnOGRE::IgnOGRE" but the target was not
found. Perhaps a find_package() call is missing for an IMPORTED target, or
an ALIAS target is missing?
Call Stack (most recent call first):
src/plugins/CMakeLists.txt:77 (ign_gui_add_library)
src/plugins/grid_3d/CMakeLists.txt:1 (ign_gui_add_plugin)
CMake Error at src/plugins/CMakeLists.txt:29 (add_library):
Target "Scene3D" links to target "IgnOGRE::IgnOGRE" but the target was not
found. Perhaps a find_package() call is missing for an IMPORTED target, or
an ALIAS target is missing?
Call Stack (most recent call first):
src/plugins/CMakeLists.txt:77 (ign_gui_add_library)
src/plugins/scene3d/CMakeLists.txt:1 (ign_gui_add_plugin)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was about time! 8k warnings gone!
The warnings follow these general categories:
CMakeLists. This alone corresponds to 95% of all warnings!this->ogreMaterial == nullptr;)Ogre::MaterialManager::Listenershould be in the dll interface like all other classes we're inheriting from.inconsistent dll linkageforBaseDepthCamera- removed the visibility since it's a header-only class and shouldn't need itOgreSelectionBufferPrivateclass was declared asstructbut defined asclass. I'm not sure if fixing this doesn't break ABI.Unfortunately, CI isn't blue yet because of #201 😢 I added some nullptr checks to see if that would be improved with no luck...
Test build before PR with no warnings: https://build.osrfoundation.org/job/ign_rendering-pr-win/1175/
https://github.com/osrf/buildfarmer/issues/145