Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 ➡️ 4 #213

Merged
merged 5 commits into from
Jan 28, 2021
Merged

3 ➡️ 4 #213

merged 5 commits into from
Jan 28, 2021

Conversation

chapulina
Copy link
Contributor

Do not squash, use merge commit

mabelzhang and others added 4 commits January 20, 2021 17:46
Signed-off-by: Mabel Zhang <[email protected]>

Co-authored-by: John Shepherd <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Carlos Agüero <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Jan 27, 2021
@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #213 (530014b) into ign-rendering4 (27f9977) will decrease coverage by 0.08%.
The diff coverage is 19.40%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           ign-rendering4     #213      +/-   ##
==================================================
- Coverage           52.59%   52.50%   -0.09%     
==================================================
  Files                 143      143              
  Lines               13341    13369      +28     
==================================================
+ Hits                 7017     7020       +3     
- Misses               6324     6349      +25     
Impacted Files Coverage Δ
include/ignition/rendering/RayQuery.hh 100.00% <ø> (ø)
include/ignition/rendering/RenderPassSystem.hh 100.00% <ø> (ø)
include/ignition/rendering/base/BaseCamera.hh 70.27% <ø> (ø)
include/ignition/rendering/base/BaseDepthCamera.hh 16.66% <ø> (ø)
include/ignition/rendering/base/BaseMarker.hh 43.24% <ø> (ø)
include/ignition/rendering/base/BaseScene.hh 0.00% <ø> (ø)
...clude/ignition/rendering/base/BaseThermalCamera.hh 94.44% <ø> (ø)
...nclude/ignition/rendering/ogre/OgreRenderEngine.hh 100.00% <ø> (ø)
ogre/src/OgreDepthCamera.cc 0.00% <0.00%> (ø)
ogre/src/OgreGpuRays.cc 0.00% <0.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f9977...530014b. Read the comment docs.

@chapulina chapulina merged commit a5f00f9 into ign-rendering4 Jan 28, 2021
@chapulina chapulina deleted the chapulina/3_to_4 branch January 28, 2021 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants