Fix gazebo scene viewer build #289
Conversation
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #289 +/- ##
=======================================
Coverage 57.54% 57.54%
=======================================
Files 159 159
Lines 15590 15590
=======================================
Hits 8971 8971
Misses 6619 6619 Continue to review full report at Codecov.
|
| double z = capsuleMsg.length(); | ||
| _parent->SetLocalScale(x, y, z); | ||
| _parent->AddGeometry(capsule); | ||
| // \todo(anyone) needs gazebo capsule msg |
There was a problem hiding this comment.
This package should use ign-msgs7 and the message it's there https://github.com/ignitionrobotics/ign-msgs/blob/main/proto/ignition/msgs/geometry.proto
There was a problem hiding this comment.
the errors are actually related to gazebo::msgs (we have these msgs in ignition but not in gazebo). I think we would need to add the cone and capsule msgs in gazebo: https://github.com/osrf/gazebo/tree/gazebo11/gazebo/msgs
| @@ -1833,12 +1835,13 @@ void SubSceneManager::CreateGeometryFunctionMap() | |||
| this->geomFunctions[gazebo::msgs::Geometry::BOX] = | |||
| &SubSceneManager::ProcessBox; | |||
|
|
|||
| // TODO(anyone): enable when cone protobuf msg created | |||
| // todo(anyone): enable when cone protobuf msg is created | |||
There was a problem hiding this comment.
The Cone msg is there too https://github.com/ignitionrobotics/ign-msgs/blob/main/proto/ignition/msgs/geometry.proto#L74
Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Ian Chen <[email protected]>
Summary
Fixes compile errors:
Statusdefinitiongazebo::msgs::Capsulemsg type so commented out code for creating capsules.Note The demo segfaults at run time. This does not happen in ign-rendering4. Ticketed #290
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge